Bug 461

Summary:	runit/sv sometimes won't issue down request
Product:	Busybox	Reporter:	Earl Chew <echew>
Component:	Other	Assignee:	unassigned
Status:	RESOLVED FIXED
Severity:	normal	CC:	busybox-cvs
Priority:	P3
Version:	1.14.x
Target Milestone:	---
Hardware:	PC
OS:	Windows
Host:		Target:
Build:
Attachments:	Issue down request if service is running.

Description Earl Chew 2009-07-14 15:37:59 UTC

touch /tmp/testservice/down
runsv /tmp/testservice &
sv once /tmp/testservice
sv down /tmp/testservice

The last line attempts to bring down the service, but does nothing.

Comment 1 Earl Chew 2009-07-14 15:39:14 UTC

Created attachment 469 [details]
Issue down request if service is running.

Comment 2 Denys Vlasenko 2009-07-14 22:23:29 UTC

I propose just removing this test:

	if (svstatus.want == *a)
		return 0;


it seems to be an optimization (and buggy one at that).

Comment 3 Earl Chew 2009-07-15 06:36:06 UTC

(In reply to comment #2)
> I propose just removing this test:
> 
>         if (svstatus.want == *a)
>                 return 0;

Yeah. I think that'd be better than my proposed patch.