Bug 3823

Summary:	busybox fbset doesn't apply (but does parse!) modlines
Product:	Busybox	Reporter:	Ali <ali_anwar>
Component:	Other	Assignee:	unassigned
Status:	RESOLVED FIXED
Severity:	normal	CC:	busybox-cvs
Priority:	P5
Version:	1.18.x
Target Milestone:	---
Hardware:	PC
OS:	Linux
Host:		Target:
Build:
Attachments:	patch to fix Bug 3823

Description Ali 2011-06-04 06:31:14 UTC

busybox doesn't provide a copy of /etc/fb.modes but if I have it available somehow, there's a bug in busybox-$VER/util-linux/fbset.c where it IS parsing /etc/fb.modes to find out what a modeline is and if it's listed, but it's not applying it.

root@p1022ds:~# fbset

mode "1024x768-60"

D: 64.998 MHz, H: 48.362 kHz, V: 60.002 Hz
geometry 1024 768 1024 768 32
timings 15385 160 24 29 3 136 6
accel false
rgba 8/16,8/8,8/0,8/24
endmode
root@p1022ds:~# fbset 1024x768-70
root@p1022ds:~# fbset

mode "1024x768-60"

D: 64.998 MHz, H: 48.362 kHz, V: 60.002 Hz
geometry 1024 768 1024 768 32
timings 15385 160 24 29 3 136 6
accel false
rgba 8/16,8/8,8/0,8/24
endmode
root@p1022ds:~# fbset -xres 640 -yres 480 -t 39722 48 16 33 10 96 2
root@p1022ds:~# fbset

mode "640x480-60"

D: 25.175 MHz, H: 31.469 kHz, V: 59.940 Hz
geometry 640 480 1024 768 32
timings 39722 48 16 33 10 96 2
accel false
rgba 8/16,8/8,8/0,8/24
endmode
root@p1022ds:~#

Comment 1 Ali 2011-06-04 06:37:20 UTC

Created attachment 3343 [details]
patch to fix Bug 3823

Added a bitwise operation to set value so that after parsing from fb.modes the parsed values could also be set.

Comment 2 Ali 2011-06-04 06:39:08 UTC

Comment on attachment 3343 [details]
patch to fix Bug 3823



p1022ds login: root
root@p1022ds:~# fbset
mode "1024x768-60"
        # D: 64.998 MHz, H: 48.362 kHz, V: 60.002 Hz
        geometry 1024 768 1024 768 32
        timings 15385 160 24 29 3 136 6
        accel false
        rgba 8/16,8/8,8/0,8/24
endmode
root@p1022ds:~# fbset -xres 640 -yres 480 -t 39722 48 16 33 10 96 2
root@p1022ds:~# fbset
mode "640x480-60"
        # D: 25.175 MHz, H: 31.469 kHz, V: 59.940 Hz
        geometry 640 480 1024 768 32
        timings 39722 48 16 33 10 96 2
        accel false
        rgba 8/16,8/8,8/0,8/24
endmode
root@p1022ds:~# fbset 1024x768-70
root@p1022ds:~# fbset
mode "1024x768-70
        # D: 74.996 MHz, H: 56.473 kHz, V: 70.066 Hz
        geometry 1024 768 1024 768 8
        timings 13334 144 24 29 3 136 6
        accel false
        rgba 8/16,8/8,8/0,8/24
endmode

Comment 3 Denys Vlasenko 2011-06-06 02:22:33 UTC

Fixed in git by commit 972e04607004bc265c0b894e48996232b95dbfef.

Thanks!