| Summary: | Support for building gstreamer without libxml | ||
|---|---|---|---|
| Product: | buildroot | Reporter: | Will Newton <will.newton> |
| Component: | Other | Assignee: | unassigned |
| Status: | RESOLVED FIXED | ||
| Severity: | enhancement | CC: | buildroot |
| Priority: | P5 | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| Host: | Target: | ||
| Build: | |||
| Attachments: |
Add support for building gstreamer without libxml2
Add support for building gstreamer without libxml2 Add support for building gstreamer without libxml2 |
||
Just out of interest, what functionality will be missing then? At the moment plugin registry and load/save of pipelines. It should be possible to use the binary registry and just lose load/save but I'm not sure if gstreamer can be built that way yet. It seems to be more common to simply use something like BR2_PACKAGE_GSTREAMER_XML instead of BR2_PACKAGE_GSTREAMER_WITH_XML, i.e. without the "_WITH". You shouldn't introduce a new variable GSTREAMER_XML_DEP, but do GSTREAMER_DEPENDENCIES += libxml2 similar to GSTREAMER_CONF_OPT += Having libxml2 behind host-pkgconfig doesn't matter. In gst-plugins-good In the gst-plugins-good package there is a plugin called "annodex (XML Library)". I guess it should now select BR2_PACKAGE_GSTREAMER_XML instead of BR2_PACKAGE_LIBXML2 (or both?). Created attachment 377 [details]
Add support for building gstreamer without libxml2
Hopefully this takes all the comments above into account.
(In reply to comment #5) > Hopefully this takes all the comments above into account. The config option name and the dependency variable cleanup, yes. But what about the annodex plugin? Oh, and personally I like "ifeq" more than "ifneq", especially if the true condition is the default. And while I'm nitpicking: the "enable" is superfluous, it's all about enabling and disabling in this configuration system. And I'd rather keep the description short (XML dependency) and move further information (registry ...) into a help section. But now I'll be quiet :) Created attachment 381 [details]
Add support for building gstreamer without libxml2
I've tweaked it a bti further to take into account comments. I haven't added the annodex change because I'm not sure it's worth it. It would only help a user who disabled the libxml2 dependency explicitly and then selected the annodex plugin that used libxml2.
(In reply to comment #7) > Created an attachment (id=381) [details] > Add support for building gstreamer without libxml2 > > > I've tweaked it a bti further to take into account comments. I haven't added > the annodex change because I'm not sure it's worth it. It would only help a > user who disabled the libxml2 dependency explicitly and then selected the > annodex plugin that used libxml2. I wasn't sure about the annodex plugin myself, that's why I wrote "I guess ...". Given that BR2_PACKAGE_GSTREAMER_LIBXML2 can be seen as an option to disable registry and load/save with the side effect that libxml2 is not a dependency anymore, I guess annodex doesn't have to be adjusted. So I'm fine with this. Thanks, fixed in git |
Created attachment 375 [details] Add support for building gstreamer without libxml2 Hi, This patch adds support for building gstreamer without XML enabled, which saves the space needed for libxml2 on the target. The default build behaviour should be unchanged.