Bug 351

Summary: Busybox insmod compile error
Product: Busybox Reporter: Marcel Groothuis <marcelg-openwrt>
Component: OtherAssignee: unassigned
Status: RESOLVED INVALID    
Severity: normal CC: busybox-cvs, marcelg-openwrt
Priority: P5    
Version: 1.13.x   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
Host: Linux 2.6 Debian Target: Linux 2.4 ARM
Build:
Attachments: Fixes a compile error for Busybox 1.13.4 insmod with 2.4 kernel support enabled

Description Marcel Groothuis 2009-05-27 09:03:08 UTC
Created attachment 357 [details]
Fixes a compile error for Busybox 1.13.4 insmod with 2.4 kernel support enabled 

The Busybox 1.13.4 compile error shown below occurred when enabling the Busybox option CONFIG_FEATURE_2_4_MODULES to get a working insmod for Linux 2.4 kernels. It was still working under Busybox 1.11.x.

The problem is a missing include when the configation option for 2.4 support is enabled. The attached patch solves this issue.

---
  CC      modutils/depmod.o
  CC      modutils/insmod.o
modutils/insmod.c: In function `find_module':
modutils/insmod.c:44: error: storage size of 'myuname' isn't known
modutils/insmod.c:49: warning: implicit declaration of function `uname'
modutils/insmod.c:44: warning: unused variable `myuname'
modutils/insmod.c: At top level:
modutils/insmod.c:21: warning: unused parameter 'statbuf'
modutils/insmod.c:22: warning: unused parameter 'depth'
make[4]: *** [modutils/insmod.o] Error 1
make[3]: *** [modutils] Error 2
Comment 1 Marcel Groothuis 2009-05-27 09:49:07 UTC
I just saw that this error was introduced by a patch in OpenWRT.

https://dev.openwrt.org/browser/trunk/package/busybox/patches/470-insmod_search.patch

So this bug is invalid for the official Busybox 1.13.4.