Bug 3313

Summary: mesa3d fails to build
Product: buildroot Reporter: Bartłomiej Palmowski <rotwang>
Component: OtherAssignee: Thomas Petazzoni <thomas.petazzoni>
Status: RESOLVED FIXED    
Severity: normal CC: buildroot, net147
Priority: P5    
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
Host: Target:
Build:
Attachments: patch

Description Bartłomiej Palmowski 2011-02-18 17:36:40 UTC 
In snapshot from 16th of february, mesa3d fails to build:

/home/bartek/crax/buildroot/output/host/usr/bin/i686-unknown-linux-uclibc-gcc --sysroot=/home/bartek/crax/buildroot/output/host/usr/i686-unknown-linux-uclibc/sysroot -c -I../../include -I../../src/mesa -I../../src/gallium/include -I../../src/gallium/auxiliary -pipe -fomit-frame-pointer -Os  -mtune=i686 -march=i686 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -I/home/bartek/crax/buildroot/output/host/usr/i686-unknown-linux-uclibc/sysroot/usr/include -I/home/bartek/crax/buildroot/output/host/usr/i686-unknown-linux-uclibc/sysroot/include -Wall -Wmissing-prototypes -std=c99 -ffast-math -fno-strict-aliasing  -fPIC   -D_GNU_SOURCE -DPTHREADS -DHAVE_POSIX_MEMALIGN -DUSE_EXTERNAL_DXTN_LIB=1 -DIN_DRI_DRIVER -DGLX_DIRECT_RENDERING -DGLX_INDIRECT_RENDERING -DHAVE_ALIAS main/imports.c -o main/imports.o
main/imports.c: In function '_mesa_strtod':
main/imports.c:919:20: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'loc'
main/imports.c:919:20: error: 'loc' undeclared (first use in this function)
main/imports.c:919:20: note: each undeclared identifier is reported only once for each function it appears in
main/imports.c:921:7: warning: implicit declaration of function 'newlocale'
main/imports.c:921:23: error: 'LC_CTYPE_MASK' undeclared (first use in this function)
main/imports.c:923:4: warning: implicit declaration of function 'strtod_l'
main/imports.c:927:1: warning: control reaches end of non-void function
make[3]: *** [main/imports.o] Error 1
make[3]: Leaving directory `/home/bartek/crax/buildroot/output/build/mesa3d-7.6.1/src/mesa'
make[2]: *** [subdirs] Error 1
make[2]: Leaving directory `/home/bartek/crax/buildroot/output/build/mesa3d-7.6.1/src'
make[1]: *** [default] Error 1
make[1]: Leaving directory `/home/bartek/crax/buildroot/output/build/mesa3d-7.6.1'
make: *** [/home/bartek/crax/buildroot/output/build/mesa3d-7.6.1/.stamp_built] Error 2

I've found it sufficent to apply attached patch to fix the issue
Comment 1 Bartłomiej Palmowski 2011-02-18 17:37:57 UTC 
Created attachment 3007 [details]
patch
Comment 2 Thomas Petazzoni 2011-02-18 18:31:46 UTC 
Buildroot currently packages version 7.6.1 of mesa3d, but the latest upstream version seems to be 7.9.1, in ftp://ftp.freedesktop.org/pub/mesa/7.9.1/MesaLib-7.9.1.tar.bz2. Maybe we should bump the version in BR first ?
Comment 3 Peter Korsgaard 2011-02-18 20:59:39 UTC 
(In reply to comment #2)
> Buildroot currently packages version 7.6.1 of mesa3d, but the latest upstream
> version seems to be 7.9.1, in
> ftp://ftp.freedesktop.org/pub/mesa/7.9.1/MesaLib-7.9.1.tar.bz2. Maybe we should
> bump the version in BR first ?

Possibly, but we have to be careful about the dependencies. I'm not interested in moving the entire X stack forward this close to the release.
Comment 4 Thomas Petazzoni 2011-09-18 17:08:51 UTC 
Ok, bug reproduced, will send a fix shortly.
Comment 5 Jonathan Liu 2012-07-24 12:18:42 UTC 
Fix not merged yet?
Comment 6 Thomas Petazzoni 2012-07-24 12:32:24 UTC 
Hum, apparently, no fix has been merged for this issue. I am surprised that we haven't seen this issue in the autobuilders, though.
Comment 7 Gustavo Zacarias 2013-04-04 13:57:16 UTC 
Solved by commit 5ec86b56daf9f4dc157c5b2c383b0eefb45eccd2 from Peter.