Bug 2149

Summary: xterm build failure
Product: buildroot Reporter: jsteckli
Component: OtherAssignee: unassigned
Status: RESOLVED FIXED    
Severity: minor CC: buildroot
Priority: P5    
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
Host: Target:
Build:
Attachments: Config that triggers the problem.
enable getpt() in uClibc default config

Description jsteckli 2010-06-29 14:47:03 UTC
Created attachment 2131 [details]
Config that triggers the problem.

Building xterm on git HEAD fails with the following error:

/bin/sh ./plink.sh /home/julian/src/linux-dev/buildroot-xorg/output/staging/usr/bin/i686-unknown-linux-uclibc-gcc -Os -pipe -Os  -mtune=core2 -march=core2 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -I/home/julian/src/linux-dev/buildroot-xorg/output/staging/usr/include -I/home/julian/src/linux-dev/buildroot-xorg/output/staging/include --sysroot=/home/julian/src/linux-dev/buildroot-xorg/output/staging/ -isysroot /home/julian/src/linux-dev/buildroot-xorg/output/staging -Os -pipe -Os  -mtune=core2 -march=core2 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -I/home/julian/src/linux-dev/buildroot-xorg/output/staging/usr/include -I/home/julian/src/linux-dev/buildroot-xorg/output/staging/include --sysroot=/home/julian/src/linux-dev/buildroot-xorg/output/staging/ -isysroot /home/julian/src/linux-dev/buildroot-xorg/output/staging  -L/home/julian/src/linux-dev/buildroot-xorg/output/staging/lib -L/home/julian/src/linux-dev/buildroot-xorg/output/staging/usr/lib --sysroot=/home/julian/src/linux-dev/buildroot-xorg/output/staging/ -o xterm button.o cachedGCs.o charproc.o charsets.o cursor.o data.o doublechr.o fontutils.o input.o linedata.o main.o menu.o misc.o print.o ptydata.o scrollback.o screen.o scrollbar.o tabs.o util.o xstrings.o xtermcap.o VTPrsTbl.o TekPrsTbl.o Tekproc.o -lXft -lXrender -lfontconfig -lfreetype -lX11 -lXaw7 -lXmu -lXt -lX11 -lSM -lICE -lXt -lX11 -lSM -lICE -lncurses 
testing if -lXmu is needed
testing if -lXft is needed
testing if -lXt is needed
testing if -lX11 is needed
...yes
testing if -lXrender is needed
testing if -lSM is needed
testing if -lICE is needed
...yes
testing if -lfontconfig is needed
testing if -lXt is needed
testing if -lX11 is needed
...yes
testing if -lfreetype is needed
testing if -lSM is needed
testing if -lICE is needed
testing if -lncurses is needed
...yes
testing if -lX11 is needed
...yes
testing if -lXaw7 is needed
...yes
testing if -lXmu is needed
...yes
testing if -lXt is needed
...yes
testing if -lX11 is needed
...yes
testing if -lSM is needed
...yes
testing if -lICE is needed
...yes
testing if -lXt is needed
...yes
testing if -lX11 is needed
...yes
testing if -lSM is needed
...yes
testing if -lICE is needed
...yes
testing if -lncurses is needed
...yes
/home/julian/src/linux-dev/buildroot-xorg/output/staging/usr/lib/libICE.so: warning: gethostbyaddr is obsolescent, use getaddrinfo() instead.
/home/julian/src/linux-dev/buildroot-xorg/output/staging/usr/lib/libXmu.so: warning: gethostbyname is obsolescent, use getnameinfo() instead.
main.o: In function `get_pty':
main.c:(.text+0xa58): undefined reference to `getpt'
collect2: ld returned 1 exit status
make[1]: *** [xterm] Error 1
make[1]: Leaving directory `/home/julian/src/linux-dev/buildroot-xorg/output/build/xterm-259'
make: *** [/home/julian/src/linux-dev/buildroot-xorg/output/build/xterm-259/.stamp_built] Error 2
Comment 1 Paulius Zaleckas 2010-06-29 19:03:57 UTC
Created attachment 2149 [details]
enable getpt() in uClibc default config
Comment 2 Paulius Zaleckas 2010-06-29 19:05:55 UTC
attached patch solves this issue... also it is possible to enable getpt() by executing make uclibc-menuconfig
Comment 3 Mitch Davis 2010-07-01 07:27:52 UTC
I looked at the attached patch.  Does UCLIBC_HAS_GETPT need to have an entry in the menuconfig?
Comment 4 Thomas Petazzoni 2010-07-06 15:39:21 UTC
I confirm the problem and that the proposed patch fixes it.

Peter, I've merged into a branch that I intend to send a pull request for relatively soon, but if you want to merge this patch no, please go ahead, I'll simply drop it from my branch.