Bug 1981

Summary: zlib: bump to 1.2.5
Product: buildroot Reporter: Paul Jones <paul>
Component: Outdated packageAssignee: unassigned
Status: RESOLVED FIXED    
Severity: minor CC: buildroot
Priority: P5    
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Windows   
Host: Target:
Build:
Attachments: zlib-Bump-to-1.2.5.patch

Description Paul Jones 2010-06-07 22:32:23 UTC

    
Comment 1 Paul Jones 2010-06-07 22:38:50 UTC
Whoops, forgot a description.

This patch bumps zlib to 1.2.5 and removes the two patches.
Comment 2 Thomas Petazzoni 2010-06-08 06:46:54 UTC
And maybe you also forgot to attach the patch, or is it just a bug to keep track of http://lists.busybox.net/pipermail/buildroot/2010-June/035087.html ?
Comment 3 Thomas Petazzoni 2010-06-24 10:31:12 UTC
Paul, could you attach the patch here ?
Comment 4 Paul Jones 2010-06-25 09:33:10 UTC
Created attachment 2095 [details]
zlib-Bump-to-1.2.5.patch

3rd time lucky....
Comment 5 Peter Korsgaard 2010-06-25 10:12:27 UTC
Thanks, but it doesn't seem to work here:

./configure --shared --prefix=/usr --libdir=/home/peko/source/buildroot/output/staging/usr/lib --includedir=/home/peko/source/buildroot/output/staging/usr/include )
Checking for shared library support...
Building shared library libz.so.1.2.5 with /home/peko/source/buildroot/output/staging/usr/bin/arm-unknown-linux-uclibcgnueabi-gcc -pipe -Os -mtune=arm926ej-s -march=armv5te -mabi=aapcs-linux -msoft-float -I/home/peko/source/buildroot/output/staging/usr/include -I/home/peko/source/buildroot/output/staging/include --sysroot=/home/peko/source/buildroot/output/staging/ -isysroot /home/peko/source/buildroot/output/staging.
Checking for off64_t... No.
Checking for fseeko... Yes.
Checking for unistd.h... Yes.
Checking whether to use vs[n]printf() or s[n]printf()... using vs[n]printf().
Checking for vsnprintf() in stdio.h... Yes.
Checking for return value of vsnprintf()... Yes.
Checking for attribute(visibility) support... Yes.
>>> zlib 1.2.5 Building
/usr/bin/make -j2 -C /home/peko/source/buildroot/output/build/zlib-1.2.5 all libz.a

...

/home/peko/source/buildroot/output/staging/usr/bin/arm-unknown-linux-uclibcgnueabi-gcc -pipe -Os  -mtune=arm926ej-s -march=armv5te -mabi=aapcs-linux -msoft-float -I/home/peko/source/buildroot/output/staging/usr/include -I/home/peko/source/buildroot/output/staging/include --sysroot=/home/peko/source/buildroot/output/staging/ -isysroot /home/peko/source/buildroot/output/staging -shared -Wl,-soname,libz.so.1,--version-script,zlib.map -pipe -Os  -mtune=arm926ej-s -march=armv5te -mabi=aapcs-linux -msoft-float -I/home/peko/source/buildroot/output/staging/usr/include -I/home/peko/source/buildroot/output/staging/include --sysroot=/home/peko/source/buildroot/output/staging/ -isysroot /home/peko/source/buildroot/output/staging -fPIC -fPIC -o libz.so.1.2.5 adler32.lo compress.lo crc32.lo deflate.lo gzclose.lo gzlib.lo gzread.lo gzwrite.lo infback.lo inffast.lo inflate.lo inftrees.lo trees.lo uncompr.lo zutil.lo  -lc -L. libz.a
arm-unknown-linux-uclibcgnueabi-gcc: libz.a: No such file or directory
make[1]: *** [libz.so.1.2.5] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory `/home/peko/source/buildroot/output/build/zlib-1.2.5'
make: *** [/home/peko/source/buildroot/output/build/zlib-1.2.5/.stamp_built] Error 2

Maybe we shouldn't do make libz.a when we build with --shared?
Comment 6 Paul Jones 2010-07-14 09:08:28 UTC
I just had another look at this and I can't seem to reproduce the problem. Manually running the same command where yours fails seems to work here:

/media/dev/buildroot-arm/output/staging/usr/bin/arm-unknown-linux-uclibcgnueabi-gcc -pipe -Os -mtune=arm920t -march=armv4t -mabi=aapcs-linux -msoft-float -I/media/dev/buildroot-arm/output/staging/usr/include -I/media/dev/buildroot-arm/output/staging/include --sysroot=/media/dev/buildroot-arm/output/staging/ -isysroot /media/dev/buildroot-arm/output/staging -shared -Wl,-soname,libz.so.1,--version-script,zlib.map -pipe -Os  -mtune=arm920t -march=armv4t -mabi=aapcs-linux -msoft-float -I/media/dev/buildroot-arm/output/staging/usr/include -I/media/dev/buildroot-arm/output/staging/include --sysroot=/media/dev/buildroot-arm/output/staging/ -isysroot /media/dev/buildroot-arm/output/staging -fPIC -fPIC -o libz.so.1.2.5 adler32.lo compress.lo crc32.lo deflate.lo gzclose.lo gzlib.lo gzread.lo gzwrite.lo infback.lo inffast.lo inflate.lo inftrees.lo trees.lo uncompr.lo zutil.lo  -lc  -L. libz.a

(as an aside - how did you get so many repeated command line options?)

This is the output from the normal build:

./configure --shared --prefix=/usr --libdir=/media/dev/buildroot-arm/output/staging/usr/lib --includedir=/media/dev/buildroot-arm/output/staging/usr/include )
Checking for shared library support...
Building shared library libz.so.1.2.5 with /media/dev/buildroot-arm/output/staging/usr/bin/arm-unknown-linux-uclibcgnueabi-gcc --sysroot=/media/dev/buildroot-arm/output/staging.
Checking for off64_t... Yes.
Checking for fseeko... Yes.
Checking for unistd.h... Yes.
Checking whether to use vs[n]printf() or s[n]printf()... using vs[n]printf().
Checking for vsnprintf() in stdio.h... Yes.
Checking for return value of vsnprintf()... Yes.
Checking for attribute(visibility) support... Yes.
>>> zlib 1.2.5 Building
/usr/bin/make -j3 -C /media/dev/buildroot-arm/output/build/zlib-1.2.5 all libz.a
.....
/media/dev/buildroot-arm/output/staging/usr/bin/arm-unknown-linux-uclibcgnueabi-gcc --sysroot=/media/dev/buildroot-arm/output/staging -shared -Wl,-soname,libz.so.1,--version-script,zlib.map -pipe -O2  -mtune=arm920t -march=armv4t -mabi=aapcs-linux -msoft-float -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -I/media/dev/buildroot-arm/output/staging/usr/include -I/media/dev/buildroot-arm/output/staging/include -fPIC -fPIC -D_LARGEFILE64_SOURCE=1 -o libz.so.1.2.5 adler32.lo compress.lo crc32.lo deflate.lo gzclose.lo gzlib.lo gzread.lo gzwrite.lo infback.lo inffast.lo inflate.lo inftrees.lo trees.lo uncompr.lo zutil.lo  -lc -L/media/dev/buildroot-arm/output/staging/lib -L/media/dev/buildroot-arm/output/staging/usr/lib -L. libz.a
rm -f libz.so libz.so.1
ln -s libz.so.1.2.5 libz.so
ln -s libz.so.1.2.5 libz.so.1
/media/dev/buildroot-arm/output/staging/usr/bin/arm-unknown-linux-uclibcgnueabi-gcc --sysroot=/media/dev/buildroot-arm/output/staging -pipe -O2  -mtune=arm920t -march=armv4t -mabi=aapcs-linux -msoft-float -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -I/media/dev/buildroot-arm/output/staging/usr/include -I/media/dev/buildroot-arm/output/staging/include -fPIC -D_LARGEFILE64_SOURCE=1 -o examplesh example.o -L. libz.so.1.2.5
/media/dev/buildroot-arm/output/staging/usr/bin/arm-unknown-linux-uclibcgnueabi-gcc --sysroot=/media/dev/buildroot-arm/output/staging -pipe -O2  -mtune=arm920t -march=armv4t -mabi=aapcs-linux -msoft-float -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -I/media/dev/buildroot-arm/output/staging/usr/include -I/media/dev/buildroot-arm/output/staging/include -fPIC -D_LARGEFILE64_SOURCE=1 -o minigzipsh minigzip.o -L. libz.so.1.2.5
make[1]: Leaving directory `/media/dev/buildroot-arm/output/build/zlib-1.2.5'
>>> zlib 1.2.5 'Installing to staging directory'
Comment 7 Peter Korsgaard 2010-07-27 21:52:28 UTC
sorry, don't know where that build issue came from - Cannot reproduce it anymore.
Committed, thanks!