Bug 1759

Summary: qt.mk stops build to prompts user
Product: buildroot Reporter: Dave Smith <dave>
Component: OtherAssignee: unassigned
Status: RESOLVED INVALID    
Severity: minor CC: buildroot
Priority: P5    
Version: 2009.02   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
Host: Target:
Build:

Description Dave Smith 2010-05-11 14:14:01 UTC 
The qt.mk makefile causes the build to stall as it prompts users during the configure step to ask them if they agree to the terms of the license. The following patch answers the prompt automatically so the build doesn't stall (this is also how the OpenWrt team does it):



Index: qt.mk
===================================================================
--- qt.mk	(revision 14)
+++ qt.mk	(working copy)
@@ -471,7 +471,7 @@
 		PKG_CONFIG_SYSROOT_DIR="$(STAGING_DIR)" \
 		PKG_CONFIG="$(PKG_CONFIG_HOST_BINARY)" \
 		PKG_CONFIG_PATH="$(STAGING_DIR)/usr/lib/pkgconfig:$(PKG_CONFIG_PATH)" \
-		./configure \
+		echo -e 'o\nyes\n' | ./configure \
 		$(if $(VERBOSE),-verbose,-silent) \
 		-force-pkg-config \
 		-embedded $(BR2_PACKAGE_QT_EMB_PLATFORM) \
Comment 1 Thomas Petazzoni 2010-05-21 12:37:46 UTC 
We already have the BR2_PACKAGE_QT_LICENSE_APPROVED option that automatically approves the license. Was this option set in your configuration ?
Comment 2 Dave Smith 2010-05-21 13:29:22 UTC 
(In reply to comment #1)
> We already have the BR2_PACKAGE_QT_LICENSE_APPROVED option that automatically
> approves the license. Was this option set in your configuration ?

Thomas: My mistake. I didn't notice that option. Frankly, I didn't even think to check it. That's a better way to handle it. Does menuconfig also allow you to choose commercial vs. open source?
Comment 3 Thomas Petazzoni 2010-05-21 21:23:56 UTC 
No, menuconfig doesn't allow it. It used to provide the option of the commercial license, but it got removed by commit 28eefec5bd12072a68035e9f900fe75a3644e946. See http://git.buildroot.net/buildroot/commit/?id=28eefec5bd12072a68035e9f900fe75a3644e946.

As the bug isn't valid, I'm closing it. If you're interested by the commercial option, don't hesitate to take the old patch, update it, check that it works, and submit it again.