Bug 1735

Summary: [PATCH] mplayer: convert to autotools infrastructure
Product: buildroot Reporter: Kelvin Cheung <keguang.zhang>
Component: OtherAssignee: unassigned
Status: RESOLVED FIXED    
Severity: enhancement CC: buildroot
Priority: P5    
Version: unspecified   
Target Milestone: 2010.11   
Hardware: PC   
OS: Linux   
Host: Kubuntu 9.10 Target: armv4
Build:
Attachments: Convert mplayer to autotools infrastructure
convert mplayer to generic package infrastructure
convert mplayer to generic package infrastructure and bump to version 1.0rc3

Description Kelvin Cheung 2010-05-10 04:49:24 UTC
Created attachment 1711 [details]
Convert mplayer to autotools infrastructure

Convert mplayer to autotools infrastructure.
Comment 1 Thomas Petazzoni 2010-06-07 10:22:00 UTC
Don't set MPLAYER_CONFIGURE_CMDS but use MPLAYER_CONF_OPT instead. Remember that most ./configure options (prefix, etc.) are already passed. You just need to pass options that are specific to the package.

Here too I'd like to make sure that MPLAYER_INSTALL_TARGET_OPT is needed.

Thanks!
Comment 2 Peter Korsgaard 2010-06-07 13:43:24 UTC
(In reply to comment #1)
> Don't set MPLAYER_CONFIGURE_CMDS but use MPLAYER_CONF_OPT instead. Remember
> that most ./configure options (prefix, etc.) are already passed. You just need
> to pass options that are specific to the package.

Careful though, mplayer uses (or atleast used to use) a handwritten configure script, E.G. no autotools - And in the past it would error out on unknown configure args.
Comment 3 Gustavo Zacarias 2010-06-07 13:45:51 UTC
We should really use a newer version, 1.0rc2 is very old, has security bugs and lacks newer optimizations (neon for example).
That said they haven't released tarballs in a while now so it would be snapshot-based (svn).
Comment 4 Thomas Petazzoni 2010-06-07 14:20:46 UTC
If mplayer doesn't use the autotools, then please do not use AUTOTARGETS but GENTARGETS instead (see the Buildroot documentation for details). A short comment explaining why GENTARGETS is used instead of AUTOTARGETS would be fine (so that in the future we don't ask ourselves why the hell this package is doing ./configure and not using AUTOTARGETS).
Comment 5 Peter Korsgaard 2010-06-07 15:39:08 UTC
(In reply to comment #3)
> We should really use a newer version, 1.0rc2 is very old, has security bugs and
> lacks newer optimizations (neon for example).
> That said they haven't released tarballs in a while now so it would be
> snapshot-based (svn).

Even though it isn't the newest sw, 1.0rc3 was released last week.

http://www.mplayerhq.hu/design7/news.html#mplayer10rc3
Comment 6 Kelvin Cheung 2010-06-08 06:58:00 UTC
Created attachment 1963 [details]
convert mplayer to generic package infrastructure
Comment 7 Kelvin Cheung 2010-06-08 07:40:53 UTC
Created attachment 1969 [details]
convert mplayer to generic package infrastructure and bump to version 1.0rc3

Here is 1.0rc3.
But I don't know how to deal with the rc2 patches.
Comment 8 Thomas Petazzoni 2010-07-29 19:32:19 UTC
That's something we're going to handle post 2010.08, I think.