Bug 15931

Summary:	CBQ support removed from Linux kernel
Product:	Busybox	Reporter:	Tom "spot" Callaway <spotrh>
Component:	Networking	Assignee:	unassigned
Status:	NEW ---
Severity:	normal	CC:	admwiggin+busyboxbugs, br015, busybox-cvs
Priority:	P5
Version:	1.36.x
Target Milestone:	---
Hardware:	All
OS:	Linux
Host:		Target:
Build:
Attachments:	remove CBQ functionality Fedora's patch for removing CBQ support

Description Tom "spot" Callaway 2024-01-29 15:40:54 UTC

I noticed that networking/tc.c was failing to build against current Linux kernel headers, because CBQ support was removed:

https://github.com/torvalds/linux/commit/33241dca486264193ed68167c8eeae1fb197f3df

iproute2 responded to the removal by deleting all CBQ related functionality:

https://github.com/iproute2/iproute2/commit/07ba0af3fee132eddc1c2eab643ff4910181c993

A similar approach in tc.c may be appropriate, but I defer to your wisdom.

Comment 1 Sergei Trofimovich 2024-05-22 22:47:24 UTC

*** Bug 15934 has been marked as a duplicate of this bug. ***

Comment 2 Tianon Gravi 2024-05-29 20:56:44 UTC

Created attachment 9751 [details]
remove CBQ functionality

I've taken a very rough stab at removing the CBQ functionality in the attached patch (mirroring iproute2's approach to the situation).  I'm roughly 60% confident in my patch though, since I've never looked at this specific code before and don't actually even know what CBQ is (except that the kernel has now removed it), so would really appreciate more eyes! 😅

Comment 3 Tianon Gravi 2024-06-13 16:39:54 UTC

Now builds against the newly released buildroot 2024.05 are failing due to this O:)

Comment 4 Tom "spot" Callaway 2024-07-01 14:12:42 UTC

Tianon, your patch is very similar to what I ended up using in Fedora, the only functional difference is that instead of removing the CBQ option in print_qdisc, I just made it printf("cbq not supported"); so that people using CBQ might have a chance to know why it's no longer working and just falling through to the options list.

I'll attach that patch here.

Comment 5 Tom "spot" Callaway 2024-07-01 14:13:26 UTC

Created attachment 9760 [details]
Fedora's patch for removing CBQ support