Bug 15196

Summary:	Setting BR2_PACKAGE_RPI_FIRMWARE_CONFIG_FILE does not work
Product:	buildroot	Reporter:	mats.webjorn
Component:	Other	Assignee:	unassigned
Status:	RESOLVED INVALID
Severity:	blocker	CC:	buildroot, mats.webjorn, yann.morin.1998
Priority:	P5
Version:	2022.08.3
Target Milestone:	---
Hardware:	Other
OS:	Linux
Host:		Target:	RPi Zero 2W
Build:

Description mats.webjorn 2022-12-21 10:00:35 UTC

.config in buildroot root has been configured with
BR2_PACKAGE_RPI_FIRMWARE_CONFIG_FILE="xxx/boot/config.txt"

administrator@zzzz:~/project/buildroot/xxx/boot $ ls -l
total 8
-rw-rw-r-- 1 administrator administrator 1612 Dec 19 22:44 config.txt

But the boot partition in the image doesn't contain my version of config.txt

What is seen in build log is

INFO: vfat(boot.vfat): adding file 'rpi-firmware/config.txt' as 'rpi-firmware/config.txt' ...
INFO: vfat(boot.vfat): cmd: "MTOOLS_SKIP_CHECK=1 mcopy -sp -i '/home/administrator/project/buildroot/output/images/boot.vfat' '/home/administrator/project/buildroot/output/images/rpi-firmware/config.txt' '::'" (stderr):

Is there any other setting that needs to done?

Comment 1 mats.webjorn 2022-12-21 11:25:28 UTC

It turns out that output/images/rpi-firmware/config.txt hasn't updated with content from xxx/boot/config.txt

Comment 2 Yann E. MORIN 2022-12-21 13:10:16 UTC

Mats, All,

> output/images/rpi-firmware/config.txt hasn't updated with
> content from xxx/boot/config.txt

config.txt is instaleld by the rpi-firmware package, so when you change it
(or change BR2_PACKAGE_RPI_FIRMWARE_CONFIG_FILE to point to another file),
then you need to instruct Buildroot to reinstall the package:

    $ make rpi-firmware-reinstall

Otherwise, when changing the configuration (like changing
BR2_PACKAGE_RPI_FIRMWARE_CONFIG_FILE is), Buildroot only guarantees that
it is entorely taken into account on a full rebuild:

    $ make clean; make

See the manual:

    https://buildroot.org/downloads/manual/manual.html#_full_rebuild

Regards,
Yann E. MORIN.