Bug 11661

Summary: SegFault on fdisk, hexedit, ed due to read_line_edit dereferencing state->hist_file
Product: Busybox Reporter: Takahiro <xellworks>
Component: OtherAssignee: unassigned
Status: RESOLVED FIXED    
Severity: major CC: busybox-cvs
Priority: P5    
Version: 1.29.x   
Target Milestone: ---   
Hardware: All   
OS: Linux   
Host: Target:
Build:
Attachments: fix suggestion for lineedit.c

Description Takahiro 2019-02-02 12:02:02 UTC
Created attachment 7936 [details]
fix suggestion for lineedit.c

fdisk, hexedit and ed calls read_line_edit in libbb/lineedit.c with NULL as first argument. On line 2373 of lineedit.c of busybox version 1.29.3, state->hist_file is referenced without checking the state->flag.

This causes segmentation fault on fdisk, hexedit and ed on ARM Cortex-A9.
It somehow works on x86_64.

Attached is a fix suggestion for lineedit.c
Comment 1 Denys Vlasenko 2019-02-04 15:17:21 UTC
Fixed in git, thanks!