Bug 11631

Summary:	vlan creation with proto option is not working - again
Product:	Busybox	Reporter:	Tomasz Zeman <tomasz.zeman>
Component:	Networking	Assignee:	unassigned
Status:	RESOLVED FIXED
Severity:	normal	CC:	busybox-cvs
Priority:	P5
Version:	1.30.x
Target Milestone:	---
Hardware:	All
OS:	Linux
Host:		Target:
Build:
Attachments:	Fix the keywords[] in iplink.c

Description Tomasz Zeman 2019-01-21 21:56:45 UTC

Created attachment 7931 [details]
Fix the keywords[] in iplink.c

Hello,

I have taken busybox 1.30.0 from the https://busybox.net/downloads/

The following command:

"ip link add link eth0.2 name eth0.2.24 type vlan proto 802.1ad id 24"

is still not working as expected, after so many years.

This is following posts, bug reports:

https://bugs.busybox.net/show_bug.cgi?id=8261#c3
http://lists.busybox.net/pipermail/busybox/2013-July/079551.html


Is it possible to permanently rearrange the keywords[] array in static void vlan_parse_opt() function so she is in the same order as the enums starting with "ARG_"?

Code can be found in the following file: /networking/libiproute/iplink.c

Best regards
Tomasz Zeman

Comment 1 Denys Vlasenko 2019-01-22 08:34:56 UTC

Fixed in git, thanks!

Comment 2 Bernhard Reutner-Fischer 2019-01-22 14:34:30 UTC

We're diverging a bit when printing links:

ip link show dev eth0.2.24 > 0
bb ip link show dev eth0.2.24  > 1

@@ -1,2 +1,2 @@
-16: eth0.2.24@eth0: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN mode DEFAULT group default qlen 1000
+16: eth0.2.24@eth0: <BROADCAST,MULTICAST> mtu 1500 qdisc noop qlen 1000
     link/ether c8:5b:76:bc:16:9a brd ff:ff:ff:ff:ff:ff


what about ip -d link?

ip -d link show dev eth0.2.24 > d

@@ -1,3 +1,2 @@
-16: eth0.2.24@eth0: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN mode DEFAULT group default qlen 1000
-    link/ether c8:5b:76:bc:16:9a brd ff:ff:ff:ff:ff:ff promiscuity 0 minmtu 0 maxmtu 65535 
-    vlan protocol 802.1ad id 24 <REORDER_HDR> addrgenmode eui64 numtxqueues 1 numrxqueues 1 gso_max_size 65536 gso_max_segs 65535 
+16: eth0.2.24@eth0: <BROADCAST,MULTICAST> mtu 1500 qdisc noop qlen 1000
+    link/ether c8:5b:76:bc:16:9a brd ff:ff:ff:ff:ff:ff

i.e. we currently provide no means to print those vlan settings, AFAICT?