Bug 11326

Summary: sysvinit fails to build in latest GIT master
Product: buildroot Reporter: Timothy Pearson <tpearson>
Component: OtherAssignee: unassigned
Status: RESOLVED FIXED    
Severity: normal CC: buildroot
Priority: P5    
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: Linux   
Host: Target:
Build:
Attachments: Add missing system macro include

Description Timothy Pearson 2018-09-11 08:40:18 UTC
Created attachment 7766 [details]
Add missing system macro include

sysvinit is missing the required macro #include to build on newer glibc versions.  OpenEmbedded has already patched this, buildroot should do the same.

Tested patch attached.
Comment 1 Thomas Petazzoni 2018-09-11 09:08:37 UTC
Thanks for the bug report. Could you submit this as a proper patch on the Buildroot mailing list ? The patch on sysvinit should be Git-formatted, since sysvinit has a Git repository at http://git.savannah.nongnu.org/cgit/sysvinit.git.

Also, I see that our sysvinit package is using some 2.88 version from Debian + Debian patches. But upstream seems to be a bit active at http://git.savannah.nongnu.org/cgit/sysvinit.git, and a 2.90 version was released in June 2018. Perhaps it would make sense to use it, there is a tarball at http://download.savannah.nongnu.org/releases/sysvinit/. Since you're interested in sysvinit :-)
Comment 2 Thomas Petazzoni 2018-11-02 09:31:13 UTC
This is fixed since the bump to sysvinit 2.90 in commit https://git.buildroot.org/buildroot/commit/package/sysvinit?id=37bd607160564296d70648eafdad0dbc593a8a95. Thanks!