| Summary: | utils/check-package fails with exception depending on path prefix | ||
|---|---|---|---|
| Product: | buildroot | Reporter: | Vitaliy Lotorev <lotorev> |
| Component: | Other | Assignee: | Ricardo Martincoski <ricardo.martincoski> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | buildroot |
| Priority: | P5 | ||
| Version: | 2018.05.2 | ||
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Host: | Target: | ||
| Build: | |||
Ricardo, any chance that you look into this bug? (In reply to Thomas Petazzoni from comment #1) Vitaliy, Thomas, Sorry about the delayed answer. I just sent a series: http://patchwork.ozlabs.org/project/buildroot/list/?series=73895 The fix has *finally* been merged: https://git.buildroot.org/buildroot/commit/?id=1842bb1470cac3b8bf59b69f33b098761e07a02c |
Prepare simple external tree: $ tree=$(mktemp --directory $(pwd)/br2-external-XXXX) $ pushd $tree $ touch external.mk Run the check-package from Buildroot: $ utils/check-package --br2-external external.mk Traceback (most recent call last): File "/home/vlotorev/projects/production-vip1-sd-fc/tmp/util-aoiU/utils/check-package", line 177, in <module> __main__() File "/home/vlotorev/projects/production-vip1-sd-fc/tmp/util-aoiU/utils/check-package", line 162, in __main__ nwarnings, nlines = check_file_using_lib(fname) File "/home/vlotorev/projects/production-vip1-sd-fc/tmp/util-aoiU/utils/check-package", line 129, in check_file_using_lib nwarnings += print_warnings(cf.before()) File "/home/vlotorev/projects/production-vip1-sd-fc/tmp/util-aoiU/utils/checkpackagelib/lib_mk.py", line 106, in before package = self.PACKAGE_NAME.search(self.filename).group(1) AttributeError: 'NoneType' object has no attribute 'group' Note once './' is added to path check finishes without errors: $ utils/check-package --br2-external ./external.mk 0 lines processed 0 warnings generated The same exception raises when non-empty and meaningful package files are processed. Checked on commit https://git.buildroot.net/buildroot/commit/?id=2989e3c87a1123350728904fd789ad513e76b073