Bug 11086

Summary: download/git submodule breaks on symlinked dl folder
Product: buildroot Reporter: Michael Nosthoff <buildroot>
Component: OtherAssignee: Yann E. MORIN <yann.morin.1998>
Status: RESOLVED FIXED    
Severity: normal CC: buildroot
Priority: P5    
Version: 2018.05   
Target Milestone: ---   
Hardware: All   
OS: Linux   
Host: Target:
Build:
Attachments: Tentative to fix dl dir wen it is a symlink

Description Michael Nosthoff 2018-06-11 09:35:10 UTC 
Hi,

I'm not sure if this should be actually considered a bug but maybe this is something which should be mentioned in the documentation.

I have been symlinking the /dl folder of Buildroot to keep a central cache of downloads (I now know `export BR2_DL_DIR` might be better). This was no problem before but I ran into a problem with a git download which uses a submodule. 

So my structure is like this

/foo/buildroot-2018.05
/foo/dl

the BR folder contains a symlink to the dl folder (doesn't matter if relativ or absolute)

the checkout of the submodule fails with
fatal: Could not chdir to '../../../../../../../../dl/my_project/git/dep/my_submodule': No such file or directory

If I compare paths I notice one too many '../' in this. which relates to the dl folder being one folder higher than the dl folder in BR.

(the entry in .git/modules/dep/my_submodule/config contains the false relative worktree)

I imagine this would require some decent fiddeling to fix. So maybe a note mentioning "you should no symlink the dl folder, use BR2_DL_DIR" would be helpful.

Regards,
Michael
Comment 1 Yann E. MORIN 2018-06-11 20:10:19 UTC 
Created attachment 7626 [details]
Tentative to fix dl dir wen it is a symlink

Michael,

Could you tgry the attached patch, please?

Regards,
Yann E. MORIN.