Bug 10851

Summary: Patch to handle numpad Enter key properly
Product: buildroot Reporter: Igor Liferenko <igor.liferenko>
Component: OtherAssignee: unassigned
Status: RESOLVED INVALID    
Severity: normal CC: buildroot
Priority: P5    
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: Linux   
Host: Target:
Build:
Attachments: Patch to handle KEY_ENTER

Description Igor Liferenko 2018-03-14 02:00:39 UTC
Created attachment 7506 [details]
Patch to handle KEY_ENTER

Hello,

Numpad Enter key is not recognized in application mode.

Please consider applying the attached patch.
Comment 1 Peter Korsgaard 2018-03-14 08:31:59 UTC
Thanks. 3 comments:

- Judging from the paths in this patch, it seems to come from openwrt. Who is the author?

- kconfig comes from the Linux kernel. Has this been submitted upstream? I don't seem to see any KEY_ENTER references in there?

- We prefer patches to be submitted to the mailing list with git-style commit logs and signed-off-by. See https://buildroot.org/downloads/manual/manual.html#submitting-patches for details.
Comment 2 Igor Liferenko 2018-03-15 03:43:13 UTC
Hi,

I did a quick investigation and created this patch myself, because I could not use numpad enter key while configuring openwrt. And as I read on openwrt website that they use buildroot, I filed this bug report here. I did not submit this patch to anywhere except here.

Please help me to figure out if I should post this patch to Linux kconfig or to openwrt. Or could you please just add these changes yourself, the way it seems more appropriate. Just to make that numpad enter key work the same way as ordinary enter key in "make menuconfig".

Thanks,
Igor
Comment 3 Peter Korsgaard 2018-03-31 21:06:01 UTC
Openwrt is not directly related to Buildroot, so openwrt patches should be submitted to openwrt and not here.
Comment 4 Alexandre Esse 2019-01-04 20:35:56 UTC
Hello,

I have the same problem. And I use another workaround that doesn't involves patch on Buildroot.

Under X:
 - Return keycode is 36 (keysym 0xff0d, Return)
 - Enter (Keypad key) keycode is 104 (keysym 0xff8d, KP_Enter)

Then, I remap the Enter key with ~/.xmodmap.conf file containing one line: keycode 104 = Return

And apply this configuration: xmodmap ~/.xmodmap.conf

Then, launch: make menuconfig