Bug 10176

Summary: Rsyslog's S01logging is deleted by Busybox.mk from TARGET
Product: buildroot Reporter: Karl Krach <mail>
Component: OtherAssignee: unassigned
Status: RESOLVED FIXED    
Severity: normal CC: buildroot
Priority: P5    
Version: 2017.02   
Target Milestone: ---   
Hardware: All   
OS: Linux   
Host: Target:
Build:
Attachments: Do not remove S01logging

Description Karl Krach 2017-08-07 14:04:13 UTC
Created attachment 7166 [details]
Do not remove S01logging

It seems that when no SYSLOGD is configured in Busybox, the file $(TARGET_DIR)/etc/init.d/S01logging is removed during installation of Busybox. But in case that rsyslog also has installed a S01logging, changing the Busybox configuration will cause that the startscript of rsyslog is removed.

I ve checked busybox.mk and S01logging of rsyslog - and both seem to have the problem also in the current Buildroot master. I'm working with 2017.02 and do reproduce it only there.

Further more, I ve attached the patch with solves the problem for me. Normally, the packages do not remove their startscript - so I ve removed the startscript-removal as well.

BR, Karl
Comment 1 Arnout Vandecappelle 2017-08-08 14:04:20 UTC
Your analysis seems correct. Could you send the patch to the mailing list, as per the contribution guidelines? See https://buildroot.org/downloads/manual/manual.html#submitting-patches

You also need to do the following.

- Add your Signed-off-by line. This is a short way for you to assert that you are entitled to contribute the patch under Buildroot's GPL license.  See  http://elinux.org/Developer_Certificate_Of_Origin for more details.

- Make it a git-formatted patch.

- Add a note "Fixes https://bugs.busybox.net/show_bug.cgi?id=10176"

Thanks!
Comment 2 Thomas Petazzoni 2018-01-10 22:07:02 UTC
Fixed by https://git.buildroot.org/buildroot/commit/?id=84e835ea9261b3e844f1a18489dd89253e3eb839. Thanks for reporting the bug in the first place, and sorry for the long delay!